Skip to content

[ws-manager] Configure http client timeouts #14214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2022
Merged

[ws-manager] Configure http client timeouts #14214

merged 1 commit into from
Oct 26, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Oct 26, 2022 •
edited by atduarte
Loading

Description

Disable keep-alive in http client connections

Related Issue(s)

#14108

How to test

  • Run loadgen
  • Run pprof against ws-manager
  • Check there are no net/http.(*persistConn).writeLoop references in the goroutines

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@aledbf
aebe7fa 
[ws-manager] Configure http client timeouts
@aledbf aledbf marked this pull request as ready for review October 26, 2022 22:01
@aledbf aledbf requested a review from a team October 26, 2022 22:01
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Oct 26, 2022
@jenting
Copy link
Contributor

jenting commented Oct 26, 2022

/hold

@jenting
Copy link
Contributor

jenting commented Oct 26, 2022 •
edited by werft-gitpod-dev-com bot
Loading

Please link to the related issue 🙏

@aledbf
Copy link
Member Author

aledbf commented Oct 26, 2022

Internal link https://gitpod.slack.com/archives/C0201TXMV54/p1666816767103749

/unhold

@roboquat roboquat merged commit 4700623 into main Oct 26, 2022
@roboquat roboquat deleted the aledbf/wsl branch October 26, 2022 23:04
@nandajavarma nandajavarma mentioned this pull request Oct 27, 2022
Merged
4 tasks
@atduarte atduarte mentioned this pull request Oct 27, 2022
Closed
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Nov 3, 2022
@jenting jenting mentioned this pull request Nov 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenting jenting jenting approved these changes

Assignees

@aledbf aledbf

Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/S team: workspace Issue belongs to the Workspace team
Projects
No open projects
🌌 Workspace Team
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aledbf @jenting @roboquat